getJSDocParameterTags: no need to handle JSDocFunctionType, just return undefined#16837
Merged
2 commits merged intoJul 18, 2017
Merged
getJSDocParameterTags: no need to handle JSDocFunctionType, just return undefined#168372 commits merged into
2 commits merged into
Conversation
7a60bd1 to
75ca885
Compare
Member
|
I thought that this was legal too: (Contra the comment in the code, but that may be inaccurate) |
sandersn
approved these changes
Jul 18, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
No, turns out that /** @param {string} */ is a parse error.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was effectively dead code as
getJSDocTagswould never return a defined result if we were already in a JSDocFunctionType (which is the only timeparam.namewould be undefined).