Remove createFileMap#16810
Merged
3 commits merged intoJul 10, 2017
Merged
Conversation
sandersn
approved these changes
Jun 28, 2017
amcasey
approved these changes
Jun 28, 2017
| has(fileName: Path): boolean; | ||
| } | ||
|
|
||
| function createFileMap<T>(keyMapper: (key: string) => string): FileMap<T> { |
Author
There was a problem hiding this comment.
I had a closer look at all the uses and couldn't answer this question. They were either using keyMapper redundantly (meaning, they were canonicalizing paths multiple times) or using it to convert things to lower case. It's simpler to just remove createFileMap entirely.
createFileMap an internal detail of program.tscreateFileMap
gcnew
added a commit
to gcnew/TypeScript
that referenced
this pull request
Jul 10, 2017
This reverts commit 8c3f5e2.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #16724,
createFileMapis now only used inprogram.ts.We had publicly exposed the
FileMaptype before, but we weren't exposing any values of that type. So we can make it internal toprogram.ts. Also removed all unused methods and renamed others to resemble those inMap.