Skip to content

Add package lock to gitignore#16770

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:add-package-lock-to-gitignore
Jul 5, 2017
Merged

Add package lock to gitignore#16770
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:add-package-lock-to-gitignore

Conversation

@weswigham
Copy link
Copy Markdown
Member

This package lock file is autogenerated by npm v5+. Unless we adopt a policy to commit it and manually unlock/update versions, we should add it to our .gitignore.

@DanielRosenwasser
Copy link
Copy Markdown
Member

I think we should just add it to the repo itself. But it should be added to our .npmignore as well if they're not already.

@weswigham
Copy link
Copy Markdown
Member Author

We don't have yarn.lock in our .npmignore, which is almost the same thing. And I think new versions of npm will ignore it anyway:

One key detail about package-lock.json is that it cannot be published, and it will be ignored if found in any place other than the toplevel package. It shares a format with npm-shrinkwrap.json, which is essentially the same file, but allows publication. This is not recommended unless deploying a CLI tool or otherwise using the publication process for producing production packages. [source]

@weswigham weswigham merged commit 296660a into microsoft:master Jul 5, 2017
@weswigham weswigham deleted the add-package-lock-to-gitignore branch July 5, 2017 19:51
GulajavaMinistudio added a commit to GulajavaMinistudio/TypeScript that referenced this pull request Jul 5, 2017
@ghost ghost mentioned this pull request Oct 11, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants