Type emptyArray as never[]#16717
Closed
ghost wants to merge 1 commit into
Closed
Conversation
yuit
reviewed
Jun 27, 2017
| namespace ts { | ||
| export const scanner: Scanner = createScanner(ScriptTarget.Latest, /*skipTrivia*/ true); | ||
| export const emptyArray: any[] = []; | ||
| export const emptyArray: never[] = [] as never[]; |
Contributor
There was a problem hiding this comment.
Do you still need the casting?
Author
There was a problem hiding this comment.
Yes, otherwise I get undefined[] is not assignable to never[] error. May be related to #16651.
Author
|
I made this part of #16836 since I needed to use |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is an
any[]then any value that's possibly anemptyArraywill also be considered anany[].This should actually be a
ReadonlyArray<never>but see #16716.