Diagnostics for default class / function export in namespace#16704
Merged
DanielRosenwasser merged 2 commits intoJun 29, 2017
Conversation
This was referenced Jun 23, 2017
Member
|
Awesome, thanks for the PR! This looks good to me, can you take a look @sandersn? |
DanielRosenwasser
approved these changes
Jun 23, 2017
Contributor
Author
|
Any updates / problems with this PR @sandersn? I'd like to make sure it doesn't get too far behind Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16300 & #16301
Since default function / class exports are parsed differently from other default exports, there were no diagnostic messages for when they were included in namespaces. Additionally, attempting to compile a default class export within a namespace was causing the compiler to crash as it assumed the class had a name when it actually didn't.
Updated the checker to also check for the default modifier and added a guard when transforming class declarations to handle when there is no name.