Skip to content

do not apply format on enter for the first line#1666

Merged
vladima merged 1 commit into
masterfrom
noFormattingOnFirstLine
Jan 14, 2015
Merged

do not apply format on enter for the first line#1666
vladima merged 1 commit into
masterfrom
noFormattingOnFirstLine

Conversation

@vladima

@vladima vladima commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

Fixes #1663. New behavior is the same with old formatter. It is an open question whether comitting completion on Enter should also trigger formatting (this is something that should be addressed on VS side) but I would still pick this change to make script side of the code more robust

@mhegazy

mhegazy commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

👍

vladima added a commit that referenced this pull request Jan 14, 2015
do not apply format on enter for the first line
@vladima
vladima merged commit 0518124 into master Jan 14, 2015
@JsonFreeman

Copy link
Copy Markdown
Contributor

👍

@vladima
vladima deleted the noFormattingOnFirstLine branch January 14, 2015 18:54
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in getFormattingEditsAfterKeystroke when selecting a completion item

4 participants