Add logging to discoverTypings#16652
Merged
2 commits merged intoJul 13, 2017
Merged
Conversation
yuit
reviewed
Jun 21, 2017
| */ | ||
| export function discoverTypings( | ||
| host: TypingResolutionHost, | ||
| log: ((message: string) => void) | undefined, |
Contributor
There was a problem hiding this comment.
should this just be ((message: string) => void) with default parameter of function that do nothing.... so we don't have to check whether the log parameter is defined
Author
There was a problem hiding this comment.
We're doing this kind of pattern (if (this.log.isEnabled()) this.log.writeLine(...)) for logging in typingsInstaller, I think for performance so that we don't allocate strings that we won't need. It may not matter compared to all the I/O we're doing though.
950046a to
2e0fda7
Compare
2e0fda7 to
9090096
Compare
34c528f to
b893606
Compare
This was referenced Jul 17, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16203 (the logging part anyway)
Must wait on #16632 and then be rebased.