Add jsdoc to EOF token to catch missed @typedefs#16488
Merged
Merged
Conversation
Previously there was nothing for the @typedef to attach to, so the comment was never parsed. Now these comments attach to the EOF token.
mhegazy
approved these changes
Jun 13, 2017
Contributor
|
Please port this to release-2.4 |
Member
Author
|
OK, it's in release-2.4 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JS files that consist only of
@typedefs, the doc comments were not parsed because there was nothing for them to attach to. Now we calladdJSDocCommenton the EOF token, so they attach there.Fixes #15901