Skip to content

Add hash of project file location to project info telemetry#16397

Merged
2 commits merged into
masterfrom
projectTelemetry_id
Jun 9, 2017
Merged

Add hash of project file location to project info telemetry#16397
2 commits merged into
masterfrom
projectTelemetry_id

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 9, 2017

No description provided.

@ghost ghost requested review from billti and mhegazy June 9, 2017 14:48
@ghost ghost force-pushed the projectTelemetry_id branch from c6ac227 to b793439 Compare June 9, 2017 14:49
Comment thread src/server/editorServices.ts Outdated

export interface ProjectInfoTelemetryEventData {
/** Cryptographically secure hash of project file location. */
readonly id: string;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call this projectId instead

Copy link
Copy Markdown
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ghost ghost merged commit a757e84 into master Jun 9, 2017
@ghost ghost deleted the projectTelemetry_id branch June 9, 2017 20:12
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants