Conversation
| function canEmitSimpleArrowHead(parentNode: FunctionTypeNode | ArrowFunction, parameters: NodeArray<ParameterDeclaration>) { | ||
| const parameter = singleOrUndefined(parameters); | ||
| return parameter | ||
| && parameter.pos === parentNode.pos // may not have parsed tokens between parent and parameter |
Contributor
Author
There was a problem hiding this comment.
This existed previously and was for handling source parsed as (x) => x vs x => x.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the emitter determines whether to emit parentheses around the parameter purely based on the number of parameters and whether there are any parsed tokens between the parent node and the first parameter. However, this logic is invalid if both the parent node and the parameter are both synthesized.
This change adds a few more additional tests to ensure its valid to emit the parameter list of an arrow function or function type.
Fixes #15651