Delay signature return type instantiation#16335
Merged
Merged
Conversation
`getReturnTypeOfSignature` correctly handles an un-instantiated signature, but `instantiateSignature` used to eagerly instantiate the return type. This caused an infinite recursion in #16233. Now `instantiateSignature` doesn't instantiate the return type, but relies on `getReturnTypeOfSignature` to do it.
Member
Author
|
@ahejlsberg it turns out the machinery was completely in place already. |
Member
Author
|
CI failed because of lint in master that is now fixed. I'll merge from master. |
mhegazy
approved these changes
Jun 8, 2017
ahejlsberg
approved these changes
Jun 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delay instantiation of signature return type
getReturnTypeOfSignaturecorrectly handles an un-instantiated signature, butinstantiateSignatureused to eagerly instantiate the return type. This caused an infinite recursion in #16233.Now
instantiateSignaturedoesn't instantiate the return type, but relies ongetReturnTypeOfSignatureto do it.Fixes #16233