Master : Fix run-parallel#16283
Merged
Merged
Conversation
Contributor
Author
|
Fix #16280 |
rbuckton
suggested changes
Jun 8, 2017
| case SyntaxKind.ImportKeyword: | ||
| return true; | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
This change is unrelated to the PR.
| var isPartitionFail = partition.failed || code !== 0; | ||
| var summaryColor = isPartitionFail ? "fail" : "green"; | ||
| var summarySymbol = isPartitionFail ? Base.symbols.err : Base.symbols.ok; | ||
| if (partition.passed === 54107) { |
Contributor
Author
There was a problem hiding this comment.
Oh that was me debugging I will remove
| stats.tests += partition.tests; | ||
| duration += partition.duration; | ||
| if (partition.catastrophicError !== "") { | ||
| //{"light":false, |
Contributor
There was a problem hiding this comment.
Is this comment necessary?
Contributor
Author
There was a problem hiding this comment.
it helps to make it clear what the json object look like ....so you can be sure about (configObj.tasks && configObj.tasks[0])
Contributor
There was a problem hiding this comment.
Can you add a comment to that effect? As it stands it just looks like commented-out code.
rbuckton
approved these changes
Jun 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress to fix run-parallel.
Note: this branch is intentionally behind master so that it will have SOF exception