Conversation
mhegazy
reviewed
Jun 1, 2017
| if (callSignatures.length) { | ||
| const signature = resolveCall(node, callSignatures, candidatesOutArray); | ||
| if (getReturnTypeOfSignature(signature) !== voidType) { | ||
| if (!isInJavaScriptFile(signature.declaration) && getReturnTypeOfSignature(signature) !== voidType) { |
Contributor
There was a problem hiding this comment.
should not we check functionSymbol.members here to make sure the function has a this.prop = .. somewhere, and avoid something like new getNumber()
Contributor
Author
There was a problem hiding this comment.
Probably, but I need to fix #14056 first to properly resolve the underlying function to get to the symbols. Right now the symbol points to the local var declaration and doesn't have this information.
mhegazy
approved these changes
Jun 6, 2017
Contributor
mhegazy
left a comment
There was a problem hiding this comment.
Can you add some conformance tests for these patterns also the use of @class
mhegazy
approved these changes
Jun 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This loosens the restriction that a function must return
voidif it is to be used as a constructor when the function is defined in a JavaScript file.Fixes #15959