Stop spelling suggestions after 10 name-not-found errors#16174
Merged
Conversation
Previously, spelling suggestions stopped after name-not-found errors led to 10 *suggestions*. This may never happen for a failed import, which is the most common case for lots of name-not-found errors. Now spelling suggestions stop after the 10th name-not-found errors, which is better for performance.
mhegazy
approved these changes
May 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spelling suggestions now stop after the tenth name-not-found error, which is better for performance.
Previously, spelling suggestions stopped after name-not-found errors led to 10 suggestions. This may never happen for a failed import, which is the most common case for lots of name-not-found errors. In that worst case, we would continue to search for spelling suggestions for every name-not-found error but never find any.