Merged
Conversation
sandersn
approved these changes
May 31, 2017
Member
|
JS unit test frameworks seem unnecessarily bad. |
Contributor
|
The |
rbuckton
suggested changes
May 31, 2017
Contributor
rbuckton
left a comment
There was a problem hiding this comment.
Please take a look at the makePrintsCorrectly function before committing this. I don't think this is the correct change.
rbuckton
reviewed
May 31, 2017
| const printsCorrectly = makePrintsCorrectly("printsFileCorrectly"); | ||
| const sourceFile = createSourceFile("source.ts", ` | ||
| // Avoid eagerly creating the sourceFile so that `createSourceFile` doesn't run unless one of these tests is run. | ||
| const sourceFile = memoize(() => createSourceFile("source.ts", ` |
Contributor
There was a problem hiding this comment.
Alternatively, we can move this to a before hook
rbuckton
approved these changes
May 31, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code inside of a
describeruns immediately, while the code in anitdoesn't run until the test is started. Usingitmakes life easier if I want to debug something unrelated to these tests.