Skip to content

Make {create/update}TypeAliasDeclaration API consistent (closes #15918)#15940

Merged
sandersn merged 2 commits into
microsoft:masterfrom
phated:fix-createTypeAliasDeclaration-parameters
May 19, 2017
Merged

Make {create/update}TypeAliasDeclaration API consistent (closes #15918)#15940
sandersn merged 2 commits into
microsoft:masterfrom
phated:fix-createTypeAliasDeclaration-parameters

Conversation

@phated
Copy link
Copy Markdown
Contributor

@phated phated commented May 18, 2017

Fixes #15918

@sandersn
Copy link
Copy Markdown
Member

@phated can you fix the build break before I merge this? Callers of updateTypeAliasDeclaration need to be updated.

@phated
Copy link
Copy Markdown
Contributor Author

phated commented May 19, 2017

No problem. I didn't realize it was being used internally already.

@phated
Copy link
Copy Markdown
Contributor Author

phated commented May 19, 2017

Alright, based on the travis run, I think I've updated this properly.

@sandersn sandersn merged commit d5993ba into microsoft:master May 19, 2017
@sandersn
Copy link
Copy Markdown
Member

Thanks @phated!

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants