getAllPossiblePropertiesOfTypes: Skip primitives#15910
Merged
2 commits merged intoMay 17, 2017
Merged
Conversation
mhegazy
approved these changes
May 17, 2017
| verify.completionListContains("c", "(property) c: string"); | ||
|
|
||
| goTo.marker("f"); | ||
| verify.completionListContains("a", "(property) a: number"); |
Contributor
There was a problem hiding this comment.
worth adding something with T | null and T|undefined to make sure we do not break these in the future.
Author
There was a problem hiding this comment.
You mean like this?
function g<T>(x: T | null) {}
g({ /*completion*/ });
Contributor
There was a problem hiding this comment.
no i meant:
function g(x: {a: number} | null) {}
g({ | /* should see "a" */ })
Author
There was a problem hiding this comment.
Should be handled by the first test then. Added | undefined too.
Contributor
There was a problem hiding this comment.
sorry did not see that earlier. thanks!
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15894