getDeclarationOfKind: Improve type safety#15880
Merged
2 commits merged intoMay 16, 2017
Merged
Conversation
mhegazy
approved these changes
May 16, 2017
mhegazy
reviewed
May 16, 2017
| else { | ||
| // Method/function type parameter | ||
| let declaration = <Node>getDeclarationOfKind(symbol, SyntaxKind.TypeParameter); | ||
| let declaration: Node = getDeclarationOfKind(symbol, SyntaxKind.TypeParameter); |
Contributor
There was a problem hiding this comment.
getDeclarationOfKind<Node> for consistency
Author
There was a problem hiding this comment.
The problem is that it's typed with <T extends Declaration>. The : Node was just there so that declaration could be reassigned later. Fixed by using two separate const declarations instead of the let.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need for a cast as this function checks the type of its return value.