Skip to content

Add support for 'lib' reference directive #15780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbuckton wants to merge 17 commits into from
Closed

Add support for 'lib' reference directive #15780

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9e22efe
Add support for 'lib' reference directive
rbuckton May 11, 2017
f61beb1
Update baseline, PR feedback
rbuckton May 11, 2017
f1fe66e
Merge branch 'master' into libReferenceDirective
rbuckton May 12, 2017
2f8ae00
Address PR feedback
rbuckton May 13, 2017
8a7abbf
Merge branch 'master' into libReferenceDirective
rbuckton May 13, 2017
47ed6cc
Merge branch 'master' into libReferenceDirective
rbuckton May 30, 2017
255e733
Merge branch 'master' into libReferenceDirective
rbuckton May 31, 2017
296cf84
Merge branch 'master' into libReferenceDirective
rbuckton Jun 5, 2017
295f3c1
Swap reference paths to lib
rbuckton Jun 5, 2017
32dd033
Switch built-in libs to use lib refs
rbuckton Jun 5, 2017
55ca456
Merge branch 'master' into libReferenceDirective
rbuckton Jun 6, 2017
e9818b4
single source for libs
rbuckton Jun 9, 2017
d42a77b
Merge branch 'master' into libReferenceDirective
rbuckton Nov 8, 2017
2587d05
Simplify libs.json
rbuckton Nov 8, 2017
402d08d
Merge branch 'master' into libReferenceDirective
rbuckton Nov 8, 2017
a6508c6
Fix merge conflict
rbuckton Nov 8, 2017
e1a9b74
Fix isRecognizedTripleSlashComment
rbuckton Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into libReferenceDirective
  • Loading branch information
@rbuckton
rbuckton committed Jun 6, 2017
commit 55ca456477fabbc9648017f61876eb7d0af99a3d
2 changes: 1 addition & 1 deletion Gulpfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const librarySourceMap = [
"default.es2017=lib.es2017.full.d.ts",
"default.esnext=lib.esnext.full.d.ts",
].map(function (lib) {
var parts = lib.split("=", 2);
const parts = lib.split("=", 2);
return {
sources: ["header.d.ts", parts[0] + ".d.ts"],
target: parts[1] || ("lib." + parts[0] + ".d.ts")
Expand Down
12 changes: 10 additions & 2 deletions src/compiler/diagnosticMessages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2176,14 +2176,22 @@
"category": "Error",
"code": 2710
},
"Cannot find lib definition for '{0}'.": {
"A dynamic import call returns a 'Promise'. Make sure you have a declaration for 'Promise' or include 'ES2015' in your `--lib` option.": {
"category": "Error",
"code": 2711
},
"Cannot find lib definition for '{0}'. Did you mean '{1}'?": {
"A dynamic import call in ES5/ES3 requires the 'Promise' constructor. Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your `--lib` option.": {
"category": "Error",
"code": 2712
},
"Cannot find lib definition for '{0}'.": {
"category": "Error",
"code": 2713
},
"Cannot find lib definition for '{0}'. Did you mean '{1}'?": {
"category": "Error",
"code": 2714
},

"Import declaration '{0}' is using private name '{1}'.": {
"category": "Error",
Expand Down
12 changes: 6 additions & 6 deletions tests/baselines/reference/libReferenceDirectiveErrors.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
tests/cases/compiler/a.ts(1,1): error TS1084: Invalid 'reference' directive syntax.
tests/cases/compiler/b.ts(1,1): error TS1084: Invalid 'reference' directive syntax.
tests/cases/compiler/c.ts(1,21): error TS2711: Cannot find lib definition for 'es2015.foo'.
tests/cases/compiler/d.ts(1,21): error TS2712: Cannot find lib definition for 'es2015.collections'. Did you mean 'es2015.collection'?
tests/cases/compiler/e.ts(1,21): error TS2712: Cannot find lib definition for 'lib.es2015.d.ts'. Did you mean 'es2015'?
tests/cases/compiler/c.ts(1,21): error TS2713: Cannot find lib definition for 'es2015.foo'.
tests/cases/compiler/d.ts(1,21): error TS2714: Cannot find lib definition for 'es2015.collections'. Did you mean 'es2015.collection'?
tests/cases/compiler/e.ts(1,21): error TS2714: Cannot find lib definition for 'lib.es2015.d.ts'. Did you mean 'es2015'?


==== tests/cases/compiler/a.ts (1 errors) ====
Expand All @@ -16,12 +16,12 @@ tests/cases/compiler/e.ts(1,21): error TS2712: Cannot find lib definition for 'l
==== tests/cases/compiler/c.ts (1 errors) ====
/// <reference lib="es2015.foo" />
~~~~~~~~~~
!!! error TS2711: Cannot find lib definition for 'es2015.foo'.
!!! error TS2713: Cannot find lib definition for 'es2015.foo'.
==== tests/cases/compiler/d.ts (1 errors) ====
/// <reference lib="es2015.collections" />
~~~~~~~~~~~~~~~~~~
!!! error TS2712: Cannot find lib definition for 'es2015.collections'. Did you mean 'es2015.collection'?
!!! error TS2714: Cannot find lib definition for 'es2015.collections'. Did you mean 'es2015.collection'?
==== tests/cases/compiler/e.ts (1 errors) ====
/// <reference lib="lib.es2015.d.ts" />
~~~~~~~~~~~~~~~
!!! error TS2712: Cannot find lib definition for 'lib.es2015.d.ts'. Did you mean 'es2015'?
!!! error TS2714: Cannot find lib definition for 'lib.es2015.d.ts'. Did you mean 'es2015'?
You are viewing a condensed version of this merge commit. You can view the full changes here.