findAllReferences: Clean up uses of getWidth and getStart#15772
Conversation
ghost
commented
May 11, 2017
| const possiblePositions = getPossibleSymbolReferencePositions(sourceFile, labelName, container); | ||
| for (const position of possiblePositions) { | ||
| const node = getTouchingWord(sourceFile, position); | ||
| if (!node || node.getWidth() !== labelName.length) { |
Author
There was a problem hiding this comment.
This looks like an attempt at optimization, but getTargetLabel doesn't look that slow, and 99% of the time it's going to be to the same label.
mhegazy
approved these changes
May 11, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14004