Prevent Duplicate String Literal Completions#15754
Merged
mhegazy merged 2 commits intoMay 12, 2017
Merged
Conversation
|
@charlespierce, |
ghost
approved these changes
May 11, 2017
| sortText: "0" | ||
| }); | ||
| const name = (<LiteralType>type).text; | ||
| if (!uniques.get(name)) { |
There was a problem hiding this comment.
!uniques.has(name), and uniques.set(name, true) below.
| function getStringLiteralCompletionEntriesFromCallExpression(argumentInfo: SignatureHelp.ArgumentListInfo, typeChecker: TypeChecker): CompletionInfo | undefined { | ||
| const candidates: Signature[] = []; | ||
| const entries: CompletionEntry[] = []; | ||
| const uniques = createMap<string>(); |
There was a problem hiding this comment.
Prefer createMap<true>, since this is just used as a set.
Contributor
Author
|
@Andy-MS Updated, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15622
Added optional
uniquesparameter toaddStringLiteralCompletionsFromTypeto allow for tracking which string literal values have already been added to the list of completions. It appears the only way this could happen would be for function calls with overloads (as given in the original issue).