Fix bug for goto-definition on a TSX constructor using an alias declaration#15751
Merged
1 commit merged intoMay 11, 2017
Merged
Fix bug for goto-definition on a TSX constructor using an alias declaration#157511 commit merged into
1 commit merged into
Conversation
Contributor
|
Nop. I realize I change how error recovery is done in choose overload. So what you do is right. we no longer need that |
yuit
approved these changes
May 11, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15723
Given a default import, we currently don't get the aliased symbol (see section under
if (symbol.flags & SymbolFlags.Alias) {ingoToDefinition.ts), sosymbol.valueDeclarationisundefined. This caused an exception increateDefinitionInfo.All tests pass even with this piece of code commented out. Are there any tests that we are missing but should have?