[React-Release 2.3] Enable default type parameter in React Component class - #15512
Merged
Conversation
added 2 commits
May 1, 2017 11:53
…antiate the constructor signature with the new type arguments.
Yui (yuit)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Mohamed Hegazy (mhegazy)
May 1, 2017 20:28
15 tasks
Mohamed Hegazy (mhegazy)
approved these changes
May 1, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15455 . This is so that existed library that uses generic React component can use 2.3 (see DefinitelyTyped/DefinitelyTyped#16246) ...The long term fix will be to enable users to be able to specify type argument in JSX Expression and possible infer type argument when tagName is a React Component class. (Note for SFC we already infer type argument as we use
chooseOverloadto figure out the signature to call).