Skip to content

Fix visitEachChild for signatures#15377

Merged
rbuckton merged 1 commit into
masterfrom
fix15192
Apr 25, 2017
Merged

Fix visitEachChild for signatures#15377
rbuckton merged 1 commit into
masterfrom
fix15192

Conversation

@rbuckton
Copy link
Copy Markdown
Contributor

Fixes an issue where calling visitEachChild on a function type, constructor type, call signature, construct signature, method signature, or index signature was causing a debug assertion.

Fixes #15192

@rbuckton rbuckton requested review from a user and aozgaa April 25, 2017 18:04
@rbuckton rbuckton added this to the TypeScript 2.4 milestone Apr 25, 2017
@ghost
Copy link
Copy Markdown

ghost commented Apr 25, 2017

How does this affect code like <T>(x: any) => x is T? Does that need a lexical environment for x or T?

@rbuckton
Copy link
Copy Markdown
Contributor Author

Lexical environments for the emitter are only ever needed to hoist temporary variables when emitting javascript. Using them for types is unnecessary.

@rbuckton rbuckton merged commit 15df12d into master Apr 25, 2017
@rbuckton rbuckton deleted the fix15192 branch April 25, 2017 20:56
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants