Conversation
Contributor
Author
|
I'll also need to cherry-pick this into release-2.3 once it is merged. |
RyanCavanaugh
approved these changes
Apr 12, 2017
sandersn
approved these changes
Apr 12, 2017
Contributor
Author
|
This has been merged into release-2.3 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding
--downlevelIterationsupport, the generators transformer now always emits ayield*with a call to__values. While this is fine for cases where the yielded expression is an array or when running in a host environment withSymbol.iterator, this change breaks the case where we synthesize ayield*in an async function that contains a block-scoped variable captured in a loop body.As there is only one case in the transforms where this case can occur, I've added an
EmitFlagsflag to opt out of the new behavior for this one case.Fixes #14357