Skip to content

Use object type#15124

Merged
rbuckton merged 1 commit into
microsoft:masterfrom
falsandtru:lib.d.ts/object
Apr 14, 2017
Merged

Use object type#15124
rbuckton merged 1 commit into
microsoft:masterfrom
falsandtru:lib.d.ts/object

Conversation

@falsandtru
Copy link
Copy Markdown
Contributor

Fixes #13493

@falsandtru
Copy link
Copy Markdown
Contributor Author

@sandersn @RyanCavanaugh @mhegazy Please review.

@falsandtru
Copy link
Copy Markdown
Contributor Author

@sandersn
Copy link
Copy Markdown
Member

Let's swap @sandersn with @rbuckton. I'm not fluent enough with runtime semantics to be a useful reviewer here.

@falsandtru
Copy link
Copy Markdown
Contributor Author

I see, thanks.

@falsandtru
Copy link
Copy Markdown
Contributor Author

@rbuckton Could you?

Copy link
Copy Markdown
Contributor

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rbuckton rbuckton merged commit 28c0eed into microsoft:master Apr 14, 2017
@falsandtru
Copy link
Copy Markdown
Contributor Author

Thanks!

mhegazy added a commit that referenced this pull request Apr 19, 2017
This reverts the changes to WeakSet done in #15124 to avoid breaks in existing @types packages like @types/lodash
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants