Do not walk up control flow containers for this#15032
Merged
Merged
Conversation
References to `this` should not continue looking outside their immediate container to narrow. Introduced by #11458, which allows narrowing of captured variables inside methods of class expressions.
Member
Author
|
@sheetalkamat @mhegazy can you take a look? |
mhegazy
approved these changes
Apr 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not walk up control flow containers for
this. References tothisshould not continue looking outside their immediate container to narrow.Introduced by #11458, which allows narrowing of captured variables inside methods of class expressions. That meant
thisalso attempted to narrow outside its container, which meant that references tothiswere cached as if they were references to a single variable named "this", even though they came from different class expressions.Fixes #14860