enforce triple-equals#15013
Merged
Merged
Conversation
Closed
| const encoded = this.scriptSnapshotShim.getChangeRange(oldSnapshotShim.scriptSnapshotShim); | ||
| // TODO: should this be '==='? | ||
| if (encoded == null) { | ||
| if (encoded === null) { |
Member
There was a problem hiding this comment.
Has this been verified to not be an intentional null + undefined check?
Contributor
Author
There was a problem hiding this comment.
Looking at the blame and PR where the TODO was introduced, it's clear that it should be ===.
Link: #3529 (diff)
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
triple-equalsrule to tslint and replaced==with===and!=with!==.