Add -noEmit compiler flag that skips the emit stage in ts.compile()#1501
Merged
Conversation
Contributor
There was a problem hiding this comment.
Please move this to verifyCompilerOptions in parser.ts
Contributor
|
👍 |
Member
There was a problem hiding this comment.
"Option 'noEmit' cannot be specified with options 'out' or 'outDir'."
Actually, I see that this is not consistent with other messages. I'll take care of this myself.
DanielRosenwasser
added a commit
that referenced
this pull request
Dec 18, 2014
Add -noEmit compiler flag that skips the emit stage in ts.compile()
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1172
I'm not sure about the third commit. -out and -outDir are optional to begin with, and a lot of the other options also don't make sense when not emitting - -emitBOM, -mapRoot, -module, -preserveConstEnums, -removeComments, -sourceMap, -sourceRoot. Should it check for all these parameters? Or just give -noEmit precedence and silently ignore them (i.e. just the first two commits)?