Fixed "TypeError: invalid data" when executables run by exec exited with non-zero code.#1500
Merged
Conversation
…ith non-zero code. The original error was because process.stderr only allows writing Strings or Buffers, but status is a Number. Also, the message parameter of the "error" handler is just the amalgam of all output written to stderr. This is already logged by the "stderr" handler, so there's no need to write it to process.stderr again.
Contributor
|
thanks! |
mhegazy
added a commit
that referenced
this pull request
Dec 16, 2014
Fixed "TypeError: invalid data" when executables run by exec exited with non-zero code.
Contributor
Author
|
A side effect of this change is that Travis builds won't fail any more for broken tests, because the "error" handler calls complete() instead of fail(). Before this change it would throw the TypeError before it could call complete() so it would fail for that reason. I will make a new pullreq to fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original error was because process.stderr only allows writing Strings or Buffers, but status is a Number.
Also, the message parameter of the "error" handler is just the amalgam of all output written to stderr. This is already logged by the "stderr" handler, so there's no need to write it to process.stderr again.
Before:
After: