Skip to content

Add missing methods for FormData type#14859

Merged
mhegazy merged 2 commits into
microsoft:masterfrom
NColey:form-data-methods
Mar 29, 2017
Merged

Add missing methods for FormData type#14859
mhegazy merged 2 commits into
microsoft:masterfrom
NColey:form-data-methods

Conversation

@NColey
Copy link
Copy Markdown
Contributor

@NColey NColey commented Mar 26, 2017

Fixes #14813.

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 26, 2017

@NColey,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 26, 2017

@NColey, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@NColey NColey mentioned this pull request Mar 26, 2017
Closed
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Mar 26, 2017

Thanks for your PR. these files are not manually edited, they are auto-generatd from a script in . You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TSJS-lib-generator.

Changes should be done in https://github.com/Microsoft/TSJS-lib-generator instead.

Please find more information at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy closed this Mar 26, 2017
@mhegazy mhegazy reopened this Mar 26, 2017
@msftclas
Copy link
Copy Markdown

msftclas commented Mar 26, 2017

@NColey,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Mar 26, 2017

Your changes to src/lib/DOM.iterable.d.ts we should take, please revert the other changes and send them to TSJS-lib-generator instead.

@NColey
Copy link
Copy Markdown
Contributor Author

NColey commented Mar 26, 2017 •
edited
Loading

Hi @mhegazy I reverted the unnecessary changes leaving just the updates to src/lib/DOM.iterable.d.ts and moved the rest to the following PR in TSJS-lib-generator. Let me know if there is anything else I should do, thanks!

mhegazy
mhegazy suggested changes Mar 29, 2017
View reviewed changes
Comment thread src/lib/dom.iterable.d.ts Outdated
/**
* Returns an array of key, value pairs for every entry in the list
*/
entries(): IterableIterator<[string, any]>;
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from spec, the values are string | File; that applies to value, entries and [Symbol.iterator].

Copy link
Copy Markdown
Contributor Author

@NColey NColey Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the PR with the appropriate types, thanks!

@mhegazy mhegazy merged commit 3ab7c86 into microsoft:master Mar 29, 2017
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Mar 29, 2017

thanks!

@NColey NColey deleted the form-data-methods branch March 29, 2017 15:11
@mhegazy mhegazy mentioned this pull request Apr 19, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NColey @msftclas @mhegazy