Mark occurence item in string with a special property#14677
Merged
Conversation
mhegazy
approved these changes
Mar 15, 2017
alfaproject
reviewed
Mar 15, 2017
| end, | ||
| file: fileName, | ||
| isWriteAccess, | ||
| isWriteAccess |
There was a problem hiding this comment.
Don't remove the trailing comma (;
Contributor
There was a problem hiding this comment.
the diff only shows the changed property, and next time when someone adds/removes a property same occurs.
that happens to be the main reason why ES2017 supports trailing commas in argument lists, see https://github.com/tc39/proposal-trailing-function-commas
There was a problem hiding this comment.
Exactly. Git attribution, less lines changes, less conflicts (;
Author
There was a problem hiding this comment.
Ha that does make sense. Thanks for pointing out! will update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #12780