abstract code in FindReferences from concrete way of creating result reference entry to seamlessly reuse the same code for gotoImplementation#14637
Merged
Conversation
…reference entry to seamlessly reuse the same code for gotoImplementation
Contributor
Author
|
NOTE: the change in
|
mhegazy
approved these changes
Mar 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GotoImplementation in Roslyn requires us to return more data that we used to so now we use FindReferences directly since this code used to create
ReferenceEntrytype as a result. This PR allows to parameterize FindReferences with the way how to create result value so the same code in FindReferences can be used to return data forgotoImplementationandfindReferencesrequests