Skip to content

Actually fail the surrounding jake task on errors in compileFile()#1460

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
Arnavion:compilefile-fail-task-on-error
Dec 12, 2014
Merged

Actually fail the surrounding jake task on errors in compileFile()#1460
mhegazy merged 1 commit into
microsoft:masterfrom
Arnavion:compilefile-fail-task-on-error

Conversation

@Arnavion
Copy link
Copy Markdown
Contributor

@Arnavion Arnavion commented Dec 12, 2014

Will cause builds to actually fail now. See #1459

fail() already prints to console so a separate print isn't needed.

> jake generate-code-coverage
node bin/tsc.js --module commonjs -noImplicitAny -removeComments --preserveConstEnums --out scripts/processDiagnosticMessages.js -sourcemap -mapRoot file:////home/travis/build/Microsoft/TypeScript/scripts scripts/processDiagnosticMessages.ts
scripts/processDiagnosticMessages.ts(18,9): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(19,9): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(19,30): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(20,9): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(20,88): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(24,25): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(25,20): error TS2304: Cannot find name 'sys'.
scripts/processDiagnosticMessages.ts(37,5): error TS2304: Cannot find name 'sys'.
jake aborted.
Error: Compilation of scripts/processDiagnosticMessages.js unsuccessful
    at api.fail (/home/travis/build/Microsoft/TypeScript/node_modules/jake/lib/api.js:336:18)
    at null.<anonymous> (/home/travis/build/Microsoft/TypeScript/Jakefile:245:13)
(See full trace by running task with --trace)
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
The command "npm test" exited with 1.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Dec 12, 2014

👍

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Dec 12, 2014

👍

Thanks @Arnavion! Can you just merge with master to sync up and trigger a Travis build? We just want to ensure all the bits are now playing nicely.

@Arnavion
Copy link
Copy Markdown
Contributor Author

Arnavion commented Dec 12, 2014

Rebased onto master

mhegazy added a commit that referenced this pull request Dec 12, 2014
@mhegazy
Merge pull request #1460 from Arnavion/compilefile-fail-task-on-error
90a9b34 
Actually fail the surrounding jake task on errors in compileFile()
@mhegazy mhegazy merged commit 90a9b34 into microsoft:master Dec 12, 2014
@Arnavion Arnavion deleted the compilefile-fail-task-on-error branch December 12, 2014 17:04
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Arnavion @CyrusNajmabadi @DanielRosenwasser @mhegazy