Skip to content

conditionals are now introduce indentation scope#1437

Merged
vladima merged 2 commits into
masterfrom
formatting_conditionals
Dec 11, 2014
Merged

conditionals are now introduce indentation scope#1437
vladima merged 2 commits into
masterfrom
formatting_conditionals

Conversation

@vladima

@vladima vladima commented Dec 10, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@DanielRosenwasser

Copy link
Copy Markdown
Member

Should you have a test for indentation inheritance?

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

That sounds like a good additional test.

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

👍

@vladima

vladima commented Dec 11, 2014

Copy link
Copy Markdown
Contributor Author

@mhegazy Should this one also go to 1.4 ?

@DanielRosenwasser

Copy link
Copy Markdown
Member

Actually, yes, good catch. I'd cherry-pick it off and just push out to release-1.4.

vladima added a commit that referenced this pull request Dec 11, 2014
conditionals are now introduce indentation scope
@vladima
vladima merged commit 997aadb into master Dec 11, 2014
@vladima
vladima deleted the formatting_conditionals branch December 12, 2014 04:23
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants