[Master] Fix 13893: Fix runtime crash when class is used before declaration#14307
Merged
Conversation
mhegazy
reviewed
Mar 20, 2017
| // we want to check for block-scoped | ||
| if (meaning & SymbolFlags.BlockScopedVariable) { | ||
| if (meaning & SymbolFlags.BlockScopedVariable || | ||
| ((meaning & SymbolFlags.Class || meaning & SymbolFlags.Enum) && (meaning & SymbolFlags.Value) === SymbolFlags.Value)) { |
Contributor
There was a problem hiding this comment.
(meaning & SymbolFlags.Value) instead of (meaning & SymbolFlags.Value) === SymbolFlags.Value
Contributor
Author
There was a problem hiding this comment.
We have to check that the meaning flag is strictly looking for symbolFlags.value because other we will also issue an error when used in type location as well
Contributor
There was a problem hiding this comment.
U are correct. Sorry about that.
mhegazy
approved these changes
Mar 20, 2017
Contributor
mhegazy
left a comment
There was a problem hiding this comment.
can you also add a test for:
function f() {
new C2(); // OK
}
class C2 { }and
class C3 {
static intance = new C3();
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13893