fix #11463, null assertion block uninitialized error#14020
Merged
mhegazy merged 2 commits intoMay 23, 2017
Conversation
Contributor
|
sorry for the delay. @HerringtonDarkholme can you please refresh the PR? |
Contributor
Author
|
Updated to the latest master. |
Contributor
|
thanks @HerringtonDarkholme, and sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11463. If an identifier is asserted with
!, assume it has been initialized.The change can be more local by adding the check before reporting uninitialized error, but it seems
assumeInitializedcan help flow type checking return faster. And it does not impact current type checking. (since we cannot assign nullable value to variable with non-nullable declared type under strictNullChekcs). Your kind review is helpful if I got something wrong here!Test for new feature is added. Tests related to
null | undefinedhas already been included in functionf6.