Fix "semicolon" lint rule options (was not enabled)#13999
Merged
Conversation
yuit
approved these changes
Feb 10, 2017
sandersn
reviewed
Feb 11, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
This change introduces quite a few rogue ^Ms scattered around. I'm not sure if they're real or not, but worth checking out.
They're not in every file, though. Is there some pattern?
mhegazy
approved these changes
Feb 11, 2017
Author
|
@sandersn Looks like |
Member
|
That sounds like a good idea to me. |
Author
|
Added #14391 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has probably been disabled since #12201. (See palantir/tslint#889)