Remove redundant initialization code from the constructor of SyntaxTreeCache#1371
Merged
Conversation
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
vladima
added a commit
that referenced
this pull request
Dec 4, 2014
Remove redundant initialization code from the constructor of SyntaxTreeCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All calls to SyntaxTreeCache begin with
initializemethod that re-createsSyntaxTreeCacheso this initial creation will be dropped on the floor. Also this fixes #1338. If so happens that code will be replaced right before callingdispose- then managed side will shutdown old engine and create a new one + create new shim for the language service. Code that I've removed tried to fetch project information from the managed side and died because of NullReferenceException since managed side does not set current project when callingdispose.