Remove all function expression allocations when speculatively parsing or looking ahead.#1368
Merged
Conversation
We now no longer fail a speculative parse just because an error was encountered at any point while speculating. instead, we allow the speculative function that is being called to determine if the parse was successful or not. Only if it decides it was not successful is parsing rewound. This improves our error recovery in several cases (esp. around arrow functions). it will also help in a followup refactoring to prevent lookahead/speculative parsing from causing lambda allocations.
…ooking ahead. Also, remove unnecessary grammar check now that the previous hack to insert a missing type argument node has been removed.
Contributor
Author
There was a problem hiding this comment.
er. will fix comment.
Contributor
Author
There was a problem hiding this comment.
we are no longer thrown off by the errant token after the comma. Instead, we still properly recognize this as a generic function call.
Contributor
|
👍 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Dec 4, 2014
Remove all function expression allocations when speculatively parsing or looking ahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, make speculative parsing much more flexible. It now no longer always rewinds just because an error was encountered during parsing. Instead, the speculative method has full control over deciding if rewinding is necessary or not. (Note: this flexibility was necessary to be able to remove the function expression allocations).