Skip to content

More exhaustive needsDotDotForPropertyAccess for integer literals#13661

Merged
rbuckton merged 1 commit into
masterfrom
fix13646
Jan 26, 2017
Merged

More exhaustive needsDotDotForPropertyAccess for integer literals#13661
rbuckton merged 1 commit into
masterfrom
fix13646

Conversation

@rbuckton
Copy link
Copy Markdown
Contributor

@rbuckton rbuckton commented Jan 24, 2017

Modifies needsDotDotForPropertyAccess to return false for the following cases:

  • Hexadecimal integer literals: 0x00000000.toString()
  • Binary integer literals (ES6+): 0b0000000000000000.toString()
  • Octal integer literals (ES6+): 0o000.toString()
  • Unprefixed octal integer literals: 000.toString()
  • Scientific E notation integer literals: 1e0.toString()

Fixes #13646

@rbuckton rbuckton merged commit 64dd806 into master Jan 26, 2017
@rbuckton rbuckton deleted the fix13646 branch January 26, 2017 20:40
@gcnew gcnew mentioned this pull request Jan 27, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hexadecimal digits calls toString, compile error results.(16进制的数字调用toString,编译出了错误的结果)

3 participants