Skip to content

do not propagate function name in property accessors#136

Merged
vladima merged 1 commit into
masterfrom
functionNameInPropertyAssignment
Jul 17, 2014
Merged

do not propagate function name in property accessors#136
vladima merged 1 commit into
masterfrom
functionNameInPropertyAssignment

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Jul 17, 2014

this fixes several issues

var x = 1
var y = { x() { x++; } }; 

Here x in x++ should refer to the var x.
Traceur emits it as

  var x = 1;
  var y = {x: function() {
      x++;
    }};

Comment thread src/compiler/parser.ts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment why this is important.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@sheetalkamat
Copy link
Copy Markdown
Member

LGTM

vladima added a commit that referenced this pull request Jul 17, 2014
do not propagate function name in property accessors
@vladima vladima merged commit 42183cf into master Jul 17, 2014
@vladima vladima deleted the functionNameInPropertyAssignment branch July 17, 2014 22:34
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants