Clean up code for getting emitted files#13598
Merged
2 commits merged intoJan 23, 2017
Merged
Conversation
0aa0a19 to
8886cef
Compare
Contributor
|
@sheetalkamat can you take a look. |
mhegazy
approved these changes
Jan 20, 2017
| /** | ||
| * Iterates over each source file to emit. | ||
| */ | ||
| export function forEachEmittedFile(host: EmitHost, sourceFiles: SourceFile[], |
Member
There was a problem hiding this comment.
I would suggest combining this with forEachExpectedEmitFile instead (eg. taking sourceFiles list as optional input) so as to get rid of duplicate logic here.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13414
The code for determining whether a file should be emitted appeared a few times. We got it right in one location, so this is really just a refactoring to deduplicate code.