Move "types": [] to tsconfig-base#13535
Merged
1 commit merged intoJan 17, 2017
Merged
Conversation
mhegazy
approved these changes
Jan 17, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were getting warnings because the compilation of
processDiagnosticMessages.tswas pulling in types unnecessarily. tsconfig-base is also used when compilingprocessDiagnosticMessages.ts, which doesn't have its owntsconfig.json, but does have compiler options added from tsconfig-base in the gulpfile. (See #13451.)