update declaration file to use intrinsic object type#13350
Merged
Conversation
mhegazy
approved these changes
Jan 9, 2017
Contributor
|
@RyanCavanaugh can you take a look. |
Contributor
|
@HerringtonDarkholme Can you also update declarations in the lib directory? |
Member
|
Looks right to me |
RyanCavanaugh
approved these changes
Jan 18, 2017
Contributor
Author
|
@falsandtru I think the lib directory will be automatically updated in next release. So no need to update in this pull request. |
Contributor
|
Oh, I don't know that automation, thanks. |
4 tasks
|
I just want to note that this breaks the |
This was referenced Feb 6, 2017
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow #12501, update declaration files to use intrinsic object type.
Only methods unconditionally throwing runtime
TypeErrorare patched. For example,Object.keysinvoked with primitive type will only throw TypeError in ES5. If we patch such methods, we will break partially ES6 compatible client.