Handle const modifier in getOccurrences#1333
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
Are there any contexts where a const modifier can appear, but where it is not allowed? What if I have the following?
class C {
const foo;
const bar;
}Currently we don't highlight modifiers when they appear in an incorrect context.
Contributor
Author
There was a problem hiding this comment.
that is not legal syntax.
Member
There was a problem hiding this comment.
Maybe we should add an else clause and bail out? Is it better to crash and hope to catch in dogfooding, or let it gracefully do nothing?
Member
|
👍 |
Member
|
Other than my last comment, 👍. |
mhegazy
added a commit
that referenced
this pull request
Dec 3, 2014
Handle const modifier in getOccurrences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1331. Const is not handled as a modifier, so add the handling for it.