Set symbol/flags only on (fresh) object spreads#12896
Merged
Merged
Conversation
If you spread any into an object, the type is any, which should not be changed.
And update baselines
mhegazy
approved these changes
Dec 13, 2016
Member
Author
|
@mhegazy do you want this ported to 2.1 as well? |
Contributor
|
yes please. |
Member
Author
|
OK, done. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set symbol/flags only on (fresh) object spreads. If you spread any into an object, the type is any, which should not be changed.
Previously,
checkObjectLiteralassumed that the return value ofgetSpreadTypewas a fresh object type, but this is not true when spreading an expression of typeany. So it incorrectly added flags toanythat it inherits from the rest of the object literal.In the test case,
[]contributes a ContainsWideningType flag, which previously made all uses ofanytrigger an implicit any error.