Conversation
mhegazy
left a comment
There was a problem hiding this comment.
Actually i think we should push this check into checkExternalEmitHelpers to avoid having to do this for every helper that may be needed in the future, e.g. ambient decrators, or spread/set in type position.
|
@mhegazy I chose to be explicit about the check as I wanted to avoid walking up the spine to check for an ambient context every time we call this function. |
|
I'm also seeing this on destructuring in angular2: The d.ts it's complaining about is: (selector: Type<any> | Function | string, {descendants, read}?: {
descendants?: boolean;
read?: any;
}): any;
new (selector: Type<any> | Function | string, {descendants, read}?: {
descendants?: boolean;
read?: any;
}): Query;I don't get why it says tslib cannot be found though. A |
|
@dtabuenc, have you tried with |
|
Yeah I tried with with typescript@next installed minutes before I posted. |
The call to
checkExternalEmitHelpersfor the__extendshelper was incorrectly reporting an error whenextendswas used in a declaration file with--importHelpersand a missingtslib.d.tsfile.Fixes #12724