Properly determine whether an augmentation is a ValueModule or NamespaceModule#12672
Merged
4 commits merged intoJan 25, 2017
Merged
Properly determine whether an augmentation is a ValueModule or NamespaceModule#126724 commits merged into
4 commits merged into
Conversation
Member
vladima
reviewed
Dec 5, 2016
| ==== /node_modules/lib/index.d.ts (2 errors) ==== | ||
| declare var lib: () => void; | ||
| ~~~ | ||
| !!! error TS2300: Duplicate identifier '"lib"'. |
Contributor
There was a problem hiding this comment.
this error message will look odd if this name won't be lib
mhegazy
approved these changes
Dec 28, 2016
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12030
We already correctly allow to augment
export =with type declarations.But we had incorrectly allowed augmenting with a value module, which doesn't work if you try to import
This may break some types; I'll test on DefinitelyTyped with this.
The reason this works without touching the checker is that
mergeModuleAugmentationcallsmergeSymbol, which already contains code to check for bad merges.