Fix type predicate check circularity#12210
Merged
Merged
Conversation
mhegazy
approved these changes
Nov 13, 2016
Contributor
|
The failure in travis is caused by an unmet peer dependency for tslint. will need to update tslint dependency to make this go away. |
Contributor
|
it is not only tslint issue (since build for PR that updates tslint also fails). gulp-typescript has the peer dependency problem - it is already fixed in the master of gulp-typescript and will be the part of next release (which should be sometime today) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12101.